WebRTC Code Reviews
Help | Chromium Project | Sign in
(37)

Issue 858009: Added instructions to build libjingle using gyp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Ronghua (Left WebRtc)
Modified:
2 years, 5 months ago
Reviewers:
peter, juberti
Base URL:
http://libjingle.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added instructions to build using gyp.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Lint Patch
M README View 1 2 4 chunks +46 lines, -4 lines 0 comments ? errors Download
Trybot results:

Messages

Total messages: 7
Ronghua (Left WebRtc)
Thinking to update the readme file with the new gyp build which is much simpler. ...
2 years, 5 months ago #1
juberti
On 2012/10/08 17:22:18, Ronghua wrote: > Thinking to update the readme file with the new ...
2 years, 5 months ago #2
juberti
https://webrtc-codereview.appspot.com/858009/diff/1/README File README (right): https://webrtc-codereview.appspot.com/858009/diff/1/README#newcode30 README:30: ############################################################################### I don't think we want two Section 2 ...
2 years, 5 months ago #3
Ronghua (Left WebRtc)
PTAL
2 years, 5 months ago #4
juberti
lgtm with changes below https://webrtc-codereview.appspot.com/858009/diff/1002/README File README (right): https://webrtc-codereview.appspot.com/858009/diff/1002/README#newcode30 README:30: 2. How to Build Add ...
2 years, 5 months ago #5
Ronghua (Left WebRtc)
https://webrtc-codereview.appspot.com/858009/diff/1002/README File README (right): https://webrtc-codereview.appspot.com/858009/diff/1002/README#newcode30 README:30: 2. How to Build On 2012/10/09 16:49:41, juberti wrote: ...
2 years, 5 months ago #6
juberti
2 years, 5 months ago #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1319:0ddf6d808c7f-tainted