Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
WebRTC Code Reviews
Help
|
Chromium Project
|
Sign in
(360)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
59429004
: Add ifndef to to NO_RETURN define.
Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by
ortuno
Modified:
4 years, 7 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.
More Reviews
Description
Add ifndef to to NO_RETURN define. Otherwise it conflicts with the NO_RETURN defined in third_party/WebKit/Source/wtf/Compiler.h
Patch Set 1
#
Created:
4 years, 7 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+2 lines, -0 lines
)
Patch
M
typedefs.h
View
2 chunks
+2 lines, -0 lines
0 comments
Download
Trybot results:
More>>>
<<<Less
Sign in
to try more bots
Project "webrtc" does not have a commit queue.
Messages
Total messages: 1 (1 generated)
Expand Messages
|
Collapse Messages
|
Show Generated Messages
|
Hide Generated Messages
ortuno
The CQ bit was checked by ortuno@chromium.org to run a CQ dry run
4 years, 7 months ago (2016-06-01 21:27:57 UTC)
#1
The CQ bit was checked by
ortuno@chromium.org
to run a CQ dry run
Sign in
to reply to this message.
Expand Messages
|
Collapse Messages
|
Show Generated Messages
|
Hide Generated Messages
Issue 59429004: Add ifndef to to NO_RETURN define.
Created 4 years, 7 months ago by ortuno
Modified 4 years, 7 months ago
Reviewers:
Base URL: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
245c2c2-tainted