WebRTC Code Reviews
Help | Chromium Project | Sign in
(82)

Issue 59409004: Use WebRTC API to convert byteorder in srtpfilter.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by tpsiaki
Modified:
1 year, 3 months ago
Reviewers:
juberti_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@41p
Target Ref:
refs/pending/branch-heads/41p
Project:
webrtc
Visibility:
Public.

Description

Use WebRTC API to convert byteorder in srtpfilter. This CL uses WebRTC API to convert 64bit from big-endian to host-endian, so the internal "be64_to_cpu" of libsrtp is not used. The code path of "be64_to_cpu" in newer versions of libsrtp depends on compile-time defines that are not available in WebRTC. BUG=https://code.google.com/p/chromium/issues/detail?id=328475 R=juberti@webrtc.org Review URL: https://webrtc-codereview.appspot.com/46749004 Cr-Commit-Position: refs/heads/master@{#8904} (cherry picked from commit 4b3c0d6f34c379c2a06f654b62403876b20180c6)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M talk/session/media/srtpfilter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M talk/session/media/srtpfilter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted