WebRTC Code Reviews
Help | Chromium Project | Sign in
(96)

Issue 52579004: Handle iOS devices with no rear-facing camera

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by hjon
Modified:
1 year, 5 months ago
Reviewers:
tkchin, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Handle iOS devices with no rear-facing camera Devices exist (specifically the 16GB 5th generation iPod Touch) that do not have a rear-facing camera. This CL: - Adjusts RTCAVFoundationVideoCapturerInternal so initialization doesn't fail because a rear-facing camera doesn't exist, but still logs a warning - Provides a check for whether or not a rear-facing camera can be used (useful for toggling UI elements) - Turns an attempt to switch to the rear-facing camera into a no-op with a warning. BUG=

Patch Set 1 #

Total comments: 16

Patch Set 2 : Updates from feedback #

Total comments: 3

Patch Set 3 : Update from feedback #

Total comments: 2

Patch Set 4 : Updates based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M talk/app/webrtc/objc/RTCAVFoundationVideoSource.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M talk/app/webrtc/objc/avfoundationvideocapturer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M talk/app/webrtc/objc/avfoundationvideocapturer.mm View 1 2 3 5 chunks +31 lines, -10 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCAVFoundationVideoSource.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 12 (2 generated)
hjon
Proposed changes to handle iOS devices with no rear-facing camera while not adding much additional ...
1 year, 9 months ago (2015-05-22 23:46:16 UTC) #2
tkchin
Thanks for the patch! We might consider changing it so that instead of useBackCamera as ...
1 year, 8 months ago (2015-05-29 00:06:22 UTC) #3
hjon
Re: talk/app/webrtc/objc/avfoundationvideocapturer.mm:248, when I was testing, I discovered that -[AVCaptureDeviceInput deviceInputWithDevice:error:] will just return nil ...
1 year, 8 months ago (2015-05-29 20:35:55 UTC) #4
tkchin
On 2015/05/29 20:35:55, hjon wrote: > Re: talk/app/webrtc/objc/avfoundationvideocapturer.mm:248, when I was testing, I > discovered ...
1 year, 8 months ago (2015-05-29 20:45:43 UTC) #5
hjon
I think I've updated everything as per feedback. Thanks for the tip about replying in ...
1 year, 8 months ago (2015-05-29 22:46:12 UTC) #6
hjon
Using 'Done' from the comment boxes probably was a little excessive...
1 year, 8 months ago (2015-05-29 22:46:51 UTC) #7
tkchin
Hitting done is fine. It helps keep track of items that have been completed. Can ...
1 year, 8 months ago (2015-06-09 21:12:14 UTC) #8
hjon
Updated based on feedback. https://webrtc-codereview.appspot.com/52579004/diff/20001/talk/app/webrtc/objc/avfoundationvideocapturer.mm File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right): https://webrtc-codereview.appspot.com/52579004/diff/20001/talk/app/webrtc/objc/avfoundationvideocapturer.mm#newcode249 talk/app/webrtc/objc/avfoundationvideocapturer.mm:249: if (!_backDeviceInput) { On 2015/06/09 ...
1 year, 8 months ago (2015-06-11 01:54:40 UTC) #9
tkchin
@haysc mind taking a look also? I got a presubmit error earlier about needing more ...
1 year, 8 months ago (2015-06-12 17:53:23 UTC) #11
hjon
1 year, 5 months ago (2015-08-27 20:05:34 UTC) #12
Updated based on feedback.

https://webrtc-codereview.appspot.com/52579004/diff/40001/talk/app/webrtc/obj...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://webrtc-codereview.appspot.com/52579004/diff/40001/talk/app/webrtc/obj...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:129: if (![self
canUseBackCamera]) {
On 2015/06/12 17:53:23, tkchin wrote:
> nit: access properties by dot syntax

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted