WebRTC Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 52269004: Re-enable LLVM LTO on Neon targets. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by pcc
Modified:
6 years, 1 month ago
Reviewers:
rtoy, ajm
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable LLVM LTO on Neon targets. LTO was disabled due to a GCC compiler bug that does not affect LLVM. This fixes the build in the cfi_vptr==1 configuration, which requires LLVM LTO. R=rtoy@google.com BUG=chromium:469376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dl/dl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 8 (1 generated)
pcc
6 years, 1 month ago (2015-08-13 22:50:58 UTC) #1
pcc
Ping.
6 years, 1 month ago (2015-08-26 01:24:52 UTC) #2
rtoy
lgtm. +ajm for final review. Sorry for the delay!
6 years, 1 month ago (2015-08-26 20:06:19 UTC) #4
ajm
lgtm
6 years, 1 month ago (2015-08-26 21:13:03 UTC) #5
pcc
Thanks! May I ask someone to land this for me please?
6 years, 1 month ago (2015-08-26 21:16:02 UTC) #6
ajm
I'm checking if we can enable the CQ for this repo. Will get back to ...
6 years, 1 month ago (2015-08-26 21:37:02 UTC) #7
ajm
6 years, 1 month ago (2015-08-26 21:59:15 UTC) #8
On 2015/08/26 21:37:02, ajm wrote:
> I'm checking if we can enable the CQ for this repo. Will get back to you.

So the CQ doesn't work, but at least CLs will get uploaded to the right review
site now. Landed here:
https://codereview.webrtc.org/1318803004/

You can close this one now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted