WebRTC Code Reviews
Help | Chromium Project | Sign in
(14332)

Issue 50909004: Add NetEqIlbcQualityTest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by HL
Modified:
4 years, 2 months ago
Reviewers:
minyue
CC:
webrtc-reviews_webrtc.org, tterriberry, kwiberg, Tina
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-pcmu-quality-test
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add NetEqIlbcQualityTest This is virtually the same as NetEq{Isac,Opus}QualityTest but for iLBC. BUG=2692 R=minyue@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8171735b0cb99212592cac7d9224107ea033e90a

Patch Set 1 : #

Patch Set 2 : Remove FLAGS_runtime_ms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 chunk +16 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 7 (3 generated)
HL
Please, review this too.
4 years, 2 months ago (2015-05-08 09:10:52 UTC) #2
minyue
lgtm
4 years, 2 months ago (2015-05-08 12:40:25 UTC) #5
HL
Committed patchset #2 (id:60001) manually as 8171735b0cb99212592cac7d9224107ea033e90a (presubmit successful).
4 years, 2 months ago (2015-05-12 13:04:47 UTC) #6
commit-bot
4 years, 2 months ago (2015-05-12 13:04:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8171735b0cb99212592cac7d9224107ea033e90a
Cr-Commit-Position: refs/heads/master@{#9178}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted