WebRTC Code Reviews
Help | Chromium Project | Sign in
(8635)

Issue 49239004: VoE: apply new style guide on VoE interfaces and their implementations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Jelena
Modified:
4 years, 3 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, tterriberry
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VoE: apply new style guide on VoE interfaces and their implementations Changes: 1. Ran clang-format on VoE interfaces and their implementations. 2. Replaced virtual with override in derived classes. R=henrika@webrtc.org Committed: https://crrev.com/0d266054acece70259fc1e85026194154f41e5a0 Cr-Commit-Position: refs/heads/master@{#9130}

Patch Set 1 : clang-format and virtual->override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4114 lines, -4594 lines) Patch
M webrtc/voice_engine/include/voe_audio_processing.h View 1 chunk +185 lines, -190 lines 0 comments Download
M webrtc/voice_engine/include/voe_base.h View 1 chunk +134 lines, -133 lines 0 comments Download
M webrtc/voice_engine/include/voe_codec.h View 1 chunk +110 lines, -103 lines 0 comments Download
M webrtc/voice_engine/include/voe_dtmf.h View 1 chunk +51 lines, -51 lines 0 comments Download
M webrtc/voice_engine/include/voe_external_media.h View 1 chunk +67 lines, -57 lines 0 comments Download
M webrtc/voice_engine/include/voe_file.h View 1 chunk +136 lines, -118 lines 0 comments Download
M webrtc/voice_engine/include/voe_hardware.h View 1 chunk +71 lines, -67 lines 0 comments Download
M webrtc/voice_engine/include/voe_neteq_stats.h View 1 chunk +26 lines, -26 lines 0 comments Download
M webrtc/voice_engine/include/voe_network.h View 1 chunk +38 lines, -40 lines 0 comments Download
M webrtc/voice_engine/include/voe_rtp_rtcp.h View 3 chunks +204 lines, -192 lines 0 comments Download
M webrtc/voice_engine/include/voe_video_sync.h View 1 chunk +58 lines, -58 lines 0 comments Download
M webrtc/voice_engine/include/voe_volume_control.h View 1 chunk +71 lines, -72 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.h View 1 chunk +50 lines, -50 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 44 chunks +133 lines, -133 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.h View 1 chunk +36 lines, -38 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 4 chunks +325 lines, -395 lines 0 comments Download
M webrtc/voice_engine/voe_codec_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/voice_engine/voe_dtmf_impl.h View 1 chunk +32 lines, -36 lines 0 comments Download
M webrtc/voice_engine/voe_dtmf_impl.cc View 1 chunk +166 lines, -202 lines 0 comments Download
M webrtc/voice_engine/voe_external_media_impl.h View 1 chunk +16 lines, -19 lines 0 comments Download
M webrtc/voice_engine/voe_external_media_impl.cc View 2 chunks +122 lines, -146 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.h View 1 chunk +53 lines, -57 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.cc View 3 chunks +399 lines, -511 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.h View 1 chunk +27 lines, -30 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.cc View 3 chunks +357 lines, -419 lines 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.h View 1 chunk +11 lines, -13 lines 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +30 lines, -37 lines 0 comments Download
M webrtc/voice_engine/voe_network_impl.h View 1 chunk +16 lines, -18 lines 0 comments Download
M webrtc/voice_engine/voe_network_impl.cc View 2 chunks +114 lines, -134 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.h View 1 chunk +83 lines, -86 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 8 chunks +323 lines, -372 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.h View 1 chunk +21 lines, -21 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.cc View 2 chunks +134 lines, -161 lines 0 comments Download
M webrtc/voice_engine/voe_volume_control_impl.h View 1 chunk +22 lines, -25 lines 0 comments Download
M webrtc/voice_engine/voe_volume_control_impl.cc View 1 chunk +353 lines, -425 lines 0 comments Download
M webrtc/voice_engine/voice_engine_defines.h View 9 chunks +62 lines, -65 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +15 lines, -21 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.cc View 5 chunks +56 lines, -65 lines 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 7 (3 generated)
Jelena
The changes are purely cosmetic. Please review.
4 years, 3 months ago (2015-05-04 11:52:39 UTC) #4
henrika_webrtc
Looks nice. Did not check all details. Trust your judgement here. Thanks. LGTM
4 years, 3 months ago (2015-05-04 11:58:57 UTC) #5
Jelena
Committed patchset #1 (id:40001) manually as 0d266054acece70259fc1e85026194154f41e5a0 (presubmit successful).
4 years, 3 months ago (2015-05-04 12:15:51 UTC) #6
commit-bot
4 years, 3 months ago (2015-05-04 12:15:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d266054acece70259fc1e85026194154f41e5a0
Cr-Commit-Position: refs/heads/master@{#9130}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted