Issue 46749004: Use WebRTC API to convert byteorder in srtpfilter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46749004: Use WebRTC API to convert byteorder in srtpfilter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 1 month ago by fancycode

Modified:
4 years ago

Reviewers:
juberti_webrtc, jiayang, pthatcher

CC:
webrtc-reviews_webrtc.org

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Use WebRTC API to convert byteorder in srtpfilter. This CL uses WebRTC API to convert 64bit from big-endian to host-endian, so the internal "be64_to_cpu" of libsrtp is not used. The code path of "be64_to_cpu" in newer versions of libsrtp depends on compile-time defines that are not available in WebRTC. BUG=https://code.google.com/p/chromium/issues/detail?id=328475 R=juberti@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4b3c0d6f34c379c2a06f654b62403876b20180c6

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	talk/session/media/srtpfilter.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	talk/session/media/srtpfilter_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Trybot results: linux_tsan2 win android linux_msan android_rel win_drmemory_light mac linux_asan android_arm64 mac_x64 win_baremetal mac_baremetal win_x64_rel linux_baremetal win_rel mac_asan mac_rel linux win_x64_gn_rel ios linux_rel ios_arm64 linux_gn_rel android_gn ios_rel mac_x64_rel ios_arm64_rel android_clang win_x64_gn android_gn_rel linux_gn mac_x64_gn_rel mac_x64_gn

Project "webrtc" does not have a commit queue.

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

fancycode

PTAL, this fixes an issue when compiling on Windows with newer version of libsrtp.

4 years, 1 month ago (2015-03-27 17:13:09 UTC) #1

jiayang

On 2015/03/31 07:32:50, fancycode wrote: > Could somebody please land this? I'll help.

4 years ago (2015-03-31 20:23:23 UTC) #4

fancycode

On 2015/03/31 20:23:23, jiayang wrote: > I'll help. Great, thanks.

4 years ago (2015-03-31 20:45:33 UTC) #5

commit-bot

Patchset 1 (id:??) landed as https://crrev.com/4b3c0d6f34c379c2a06f654b62403876b20180c6 Cr-Commit-Position: refs/heads/master@{#8904}

4 years ago (2015-03-31 22:02:57 UTC) #6

jiayang

4 years ago (2015-03-31 22:02:59 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4b3c0d6f34c379c2a06f654b62403876b20180c6 (presubmit successful).

Expand Messages | Collapse Messages