WebRTC Code Reviews
Help | Chromium Project | Sign in
(1857)

Issue 46109004: Handle the case when hoststring is empty. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by tommi
Modified:
4 years, 1 month ago
Reviewers:
magjed
CC:
webrtc-reviews_webrtc.org, tterriberry, qiang.lu, Niklas, yujie.mao, ajm
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix GetServiceTypeAndHostnameFromUri instead #

Messages

Total messages: 9 (1 generated)
tommi
4 years, 1 month ago (2015-04-24 11:29:26 UTC) #2
magjed
lgtm The title of this CL is a bit misleading. We already handle the case ...
4 years, 1 month ago (2015-04-24 11:45:43 UTC) #3
tommi
Fix GetServiceTypeAndHostnameFromUri instead
4 years, 1 month ago (2015-04-24 13:12:41 UTC) #4
tommi
https://webrtc-codereview.appspot.com/46109004/diff/1/talk/app/webrtc/peerconnection.cc File talk/app/webrtc/peerconnection.cc (right): https://webrtc-codereview.appspot.com/46109004/diff/1/talk/app/webrtc/peerconnection.cc#newcode230 talk/app/webrtc/peerconnection.cc:230: LOG(WARNING) << "Unexpected hoststring: " << hoststring; On 2015/04/24 ...
4 years, 1 month ago (2015-04-24 13:12:48 UTC) #5
tommi
On 2015/04/24 13:12:48, tommi wrote: > https://webrtc-codereview.appspot.com/46109004/diff/1/talk/app/webrtc/peerconnection.cc > File talk/app/webrtc/peerconnection.cc (right): > > https://webrtc-codereview.appspot.com/46109004/diff/1/talk/app/webrtc/peerconnection.cc#newcode230 > ...
4 years, 1 month ago (2015-04-24 13:12:59 UTC) #6
magjed
lgtm
4 years, 1 month ago (2015-04-24 13:38:12 UTC) #7
commit-bot
Patchset 2 (id:??) landed as https://crrev.com/77d444a433d616adf3c83fa1b37098856b0c8e52 Cr-Commit-Position: refs/heads/master@{#9081}
4 years, 1 month ago (2015-04-24 13:38:53 UTC) #8
tommi
4 years, 1 month ago (2015-04-24 13:38:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
77d444a433d616adf3c83fa1b37098856b0c8e52 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted