WebRTC Code Reviews
Help | Chromium Project | Sign in
(1718)

Issue 43259004: Disables mic bump-up level if not built with chromium (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Bjorn
Modified:
4 years, 1 month ago
Reviewers:
tommi, ajm
CC:
webrtc-reviews_webrtc.org, tterriberry, kwiberg, aluebs, ajm
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disables mic bump-up level if not built with chromium In http://chromegw.corp.google.com/viewvc/chrome-internal?view=rev&revision=61016 a feature to bump up low input audio levels to a fixed value of 33%. In https://webrtc-codereview.appspot.com/43109004/ a configuration to choose an arbitrary level was added, but still using 33% as default. The original bump-up feature was added to fix audio issues in chrome, but affected also non-chrome users. This CL disables the feature for non-chrome applications. Note that the default value is set to 0, but any value up to 12 will do. Zero was selected because it is more clear that the feature is turned off. BUG=4529 R=andrew@webrtc.org, tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/fb4945101476036ee973d81f383f8bcee180691f

Patch Set 1 #

Patch Set 2 : Sloppy coder forgot to update a unittest #

Messages

Total messages: 7 (2 generated)
Bjorn
Tommi, this is basically the change I talked about. Andrew, PTAL as well since we ...
4 years, 1 month ago (2015-04-21 16:21:06 UTC) #3
tommi
lgtm
4 years, 1 month ago (2015-04-21 16:30:19 UTC) #4
ajm
lgtm
4 years, 1 month ago (2015-04-21 23:59:44 UTC) #5
commit-bot
Patchset 2 (id:??) landed as https://crrev.com/fb4945101476036ee973d81f383f8bcee180691f Cr-Commit-Position: refs/heads/master@{#9048}
4 years, 1 month ago (2015-04-22 04:40:19 UTC) #6
Bjorn
4 years, 1 month ago (2015-04-22 04:40:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb4945101476036ee973d81f383f8bcee180691f (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted