WebRTC Code Reviews
Help | Chromium Project | Sign in
(32)

Issue 42779004: Roll chromium_revision 00e438c..8d51d96 (320241:320682) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by kjellander
Modified:
4 years, 7 months ago
Reviewers:
perkj, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, Niklas, yujie.mao, ajm
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 00e438c..8d51d96 (320241:320682) Relevant changes: * src/third_party/android_tools: fd5a8ec..98a4345 Details: https://chromium.googlesource.com/chromium/src/+/00e438c..8d51d96/DEPS This required updating our Android projects to API level 22, as third_party/android_tools dropped support for API level 21. Command used: perl -pi -e "s/android-21/android-22/g" `find . -name project.properties` Using 'android update project' would also work but that changes the ANDROID_SDK_ROOT -> ANDROID_HOME, which the Chromium build toolchain doesn't set properly when build/android/envsetup.sh is sourced. Clang version was not updated in this roll. R=henrika@webrtc.org, perkj@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=8728

Patch Set 1 #

Patch Set 2 : Changed Android projects to API level 22. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/androidtests/project.properties View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/examples/android/project.properties View 1 1 chunk +1 line, -1 line 0 comments Download
M talk/examples/androidtests/project.properties View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/android/media_demo/project.properties View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/android/opensl_loopback/project.properties View 1 1 chunk +1 line, -1 line 0 comments Download
Project "webrtc" does not have a commit queue.

Messages

Total messages: 5 (0 generated)
kjellander
4 years, 7 months ago (2015-03-16 07:39:17 UTC) #1
henrika_webrtc
LGTM
4 years, 7 months ago (2015-03-16 08:39:31 UTC) #2
kjellander
+perkj for talk/OWNERS
4 years, 7 months ago (2015-03-16 08:53:37 UTC) #3
perkj
lgtm
4 years, 7 months ago (2015-03-16 08:56:13 UTC) #4
kjellander
4 years, 7 months ago (2015-03-16 09:00:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 8728 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted