WebRTC Code Reviews
Help | Chromium Project | Sign in
(1627)

Issue 38759004: audio_processing: Use fixed aggregation window in delay metrics (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Bjorn
Modified:
4 years, 4 months ago
Reviewers:
kwiberg
CC:
webrtc-reviews_webrtc.org, tterriberry, aluebs, ajm
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

audio_processing: Use fixed aggregation window in delay metrics Previously, the delay estimate history was reset every time the metrics were pulled. This required all clients to be on the same thread and make use of one call. Now we use a fixed aggregation window of one second and when a client pulls the metrics you get the latest value. Under certain circumstances like tests you would like to have the aggregation window set to the recording length. We therefore turn on the fixed aggregation window after the first call. BUG=2994 TESTED=locally on Mac and trybots R=kwiberg@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=8170

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unneccesary parentheses #

Messages

Total messages: 7 (0 generated)
Bjorn
Step 2 in the fixed aggregation window CL chain
4 years, 4 months ago (2015-01-27 12:48:31 UTC) #1
kwiberg
> Previously, the delay estimate history was reset every > time the metrics were pulled. ...
4 years, 4 months ago (2015-01-27 16:11:07 UTC) #2
Bjorn
On 2015/01/27 16:11:07, kwiberg wrote: > > Previously, the delay estimate history was reset every ...
4 years, 4 months ago (2015-01-27 16:32:09 UTC) #3
Bjorn
https://webrtc-codereview.appspot.com/38759004/diff/1/webrtc/modules/audio_processing/aec/aec_core.c File webrtc/modules/audio_processing/aec/aec_core.c (right): https://webrtc-codereview.appspot.com/38759004/diff/1/webrtc/modules/audio_processing/aec/aec_core.c#newcode1251 webrtc/modules/audio_processing/aec/aec_core.c:1251: (aec->num_delay_values >= kDelayMetricsAggregationWindow)) { On 2015/01/27 16:11:07, kwiberg wrote: ...
4 years, 4 months ago (2015-01-27 16:32:14 UTC) #4
kwiberg
On 2015/01/27 16:32:09, Bjorn wrote: > On 2015/01/27 16:11:07, kwiberg wrote: > > > Previously, ...
4 years, 4 months ago (2015-01-27 16:52:58 UTC) #5
Bjorn
On 2015/01/27 16:52:58, kwiberg wrote: > On 2015/01/27 16:32:09, Bjorn wrote: > > On 2015/01/27 ...
4 years, 4 months ago (2015-01-27 17:03:16 UTC) #6
Bjorn
4 years, 4 months ago (2015-01-27 18:10:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 8170 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted