WebRTC Code Reviews
Help | Chromium Project | Sign in
(1636)

Issue 36529004: If one of the bundled content is missing in SDP, return false to MaybeEnalbeMuxingSupport(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by braveyao1
Modified:
4 years, 6 months ago
Reviewers:
juberti_webrtc
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry
Base URL:
http://webrtc.googlecode.com/svn/trunk/
Project:
webrtc
Visibility:
Public.

Description

If one of the bundled content is missing in SDP, return false to MaybeEnalbeMuxingSupport(). Verified in chromium. Now the existing content still could work. BUG=4096 TEST=Manual Test R=juberti@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=7926

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/p2p/base/session.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
braveyao1
PTAL
4 years, 6 months ago (2014-12-16 08:28:09 UTC) #1
juberti_webrtc
lgtm with LOG below https://webrtc-codereview.appspot.com/36529004/diff/1/webrtc/p2p/base/session.cc File webrtc/p2p/base/session.cc (right): https://webrtc-codereview.appspot.com/36529004/diff/1/webrtc/p2p/base/session.cc#newcode733 webrtc/p2p/base/session.cc:733: if (!content) add a LOG(LS_WARNING) ...
4 years, 6 months ago (2014-12-16 17:19:14 UTC) #2
braveyao1
4 years, 6 months ago (2014-12-17 05:59:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r7926 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted