WebRTC Code Reviews
Help | Chromium Project | Sign in
(421)

Issue 36089004: Add a method to remove an existing renderer from the internal list of Android renderers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by AlexGl
Modified:
4 years, 4 months ago
Reviewers:
mquiros, jiayang
CC:
webrtc-reviews_webrtc.org, tterriberry, qiang.lu, Niklas, yujie.mao, ajm
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Add a method to remove an existing renderer from the internal list of Android renderers. BUG=4290 R=jiayl@webrtc.org, mquiros@google.com Committed: https://code.google.com/p/webrtc/source/detail?r=8320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java View 1 chunk +13 lines, -0 lines 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 6 (0 generated)
AlexGl
PTAL
4 years, 4 months ago (2015-02-10 23:15:30 UTC) #1
AlexGl
4 years, 4 months ago (2015-02-10 23:16:35 UTC) #2
AlexGl
Submitted on behalf of mquiros@
4 years, 4 months ago (2015-02-10 23:19:04 UTC) #3
jiayang
lgtm barring Alex's approval
4 years, 4 months ago (2015-02-10 23:20:20 UTC) #4
mquiros
On 2015/02/10 23:20:20, jiayang wrote: > lgtm barring Alex's approval LGTM (Thanks Alex)
4 years, 4 months ago (2015-02-10 23:20:48 UTC) #5
AlexGl
4 years, 4 months ago (2015-02-10 23:23:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 8320 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted