WebRTC Code Reviews
Help | Chromium Project | Sign in
(11120)

Issue 35939004: Move channel_buffer.{h,cc} to common_audio. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by kjellander
Modified:
4 years, 6 months ago
Reviewers:
ajm
CC:
webrtc-reviews_webrtc.org, tterriberry, Bjorn, kwiberg, aluebs, ajm
Base URL:
http://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Move channel_buffer.{h,cc} to common_audio. In https://code.google.com/p/webrtc/source/detail?r=8166 I added a check preventing GYP files from referencing sources above their directory level. This CL fixes the disallowed reference added in https://code.google.com/p/webrtc/source/detail?r=8157 by moving channel_buffer.{h,cc} to common_audio for real. BUG=4185 R=andrew@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=8190

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sorted alphabetically #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -219 lines) Patch
M webrtc/common_audio/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_ring_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/blocker.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/common_audio/channel_buffer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/common_audio/channel_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/common_audio.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/complex_matrix.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/matrix.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/pcm_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/modules/audio_processing/channel_buffer.h View 1 chunk +0 lines, -138 lines 0 comments Download
D webrtc/modules/audio_processing/channel_buffer.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M webrtc/modules/audio_processing/splitting_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/splitting_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Project "webrtc" does not have a commit queue.

Messages

Total messages: 4 (0 generated)
kjellander
You can most likely ignore the modules_unittests failures as I reported it in https://code.google.com/p/chromium/issues/detail?id=452885
4 years, 6 months ago (2015-01-28 13:31:51 UTC) #1
ajm
Nice, lgtm. Just some nits. https://webrtc-codereview.appspot.com/35939004/diff/1/webrtc/modules/audio_processing/test/audioproc_float.cc File webrtc/modules/audio_processing/test/audioproc_float.cc (right): https://webrtc-codereview.appspot.com/35939004/diff/1/webrtc/modules/audio_processing/test/audioproc_float.cc#newcode17 webrtc/modules/audio_processing/test/audioproc_float.cc:17: #include "webrtc/common_audio/channel_buffer.h" Alpha order ...
4 years, 6 months ago (2015-01-28 19:29:29 UTC) #2
kjellander
https://webrtc-codereview.appspot.com/35939004/diff/1/webrtc/modules/audio_processing/test/audioproc_float.cc File webrtc/modules/audio_processing/test/audioproc_float.cc (right): https://webrtc-codereview.appspot.com/35939004/diff/1/webrtc/modules/audio_processing/test/audioproc_float.cc#newcode17 webrtc/modules/audio_processing/test/audioproc_float.cc:17: #include "webrtc/common_audio/channel_buffer.h" On 2015/01/28 19:29:28, ajm wrote: > Alpha ...
4 years, 6 months ago (2015-01-28 19:48:41 UTC) #3
kjellander
4 years, 6 months ago (2015-01-28 19:57:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 8190 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted