WebRTC Code Reviews
Help | Chromium Project | Sign in
(66)

Issue 29349004: Stop compiling libjingle in WebRTC standalone. This means webrtc/libjingle, not the talk/ director…

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by pthatcher
Modified:
5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry, qiang.lu, Niklas, yujie.mao, ajm
Base URL:
https://webrtc.googlecode.com/svn/trunk
Project:
webrtc
Visibility:
Public.

Description

Stop compiling libjingle in WebRTC standalone. This means webrtc/libjingle, not the talk/ directory, which is no longer part of libjingle.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/merge_libs.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/webrtc.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 8 (1 generated)
pthatcher
2 years, 3 months ago (2014-12-23 23:01:53 UTC) #1
pthatcher
We have to keep the files there until ChromeSync and Chromoting stop compiling them, but ...
2 years, 2 months ago (2014-12-29 19:35:25 UTC) #2
pbos
I don't think we should remove these unittests before they are gone from Chrome, or ...
2 years, 2 months ago (2015-01-02 09:34:44 UTC) #3
yarycintoracampos1993
5 months ago (2016-10-23 09:35:06 UTC) #5
yarycintoracampos1993
5 months ago (2016-10-23 09:59:10 UTC) #6
yarycintoracampos1993
5 months ago (2016-10-23 10:15:58 UTC) #7
pthatcher
5 months ago (2016-10-27 16:37:24 UTC) #8
On 2016/10/23 10:15:58, yarycintoracampos1993 wrote:

lgtm


I'm not worried about rolls to Chromium for two reasons:

1.  These files never change.
2.  We don't need to roll these files any more.  In fact, we could delete them
from our repository as long as we don't roll the deletes into Chromium (as long
as the files stay there in Chromium).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted