WebRTC Code Reviews
Help | Chromium Project | Sign in
(518)

Issue 2929004: Clean up test infrastructure (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by rtoy
Modified:
7 years, 4 months ago
Reviewers:
ajm
Base URL:
https://webrtc.googlecode.com/svn/deps
Visibility:
Public.

Description

Clean up test infrastructure o Update known failures for fft16 to match reality. o Include info about tests that unexpectedly passed and tests that failed that weren't expected to fail. o Add TestOneFFT to run one FFT test (forward, inverse, or both) and use it for all test programs instead of having one for each. BUG= R=andrew@webrtc.org Committed: 5035

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update according to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -260 lines) Patch
M third_party/openmax/dl/sp/src/test/compare.c View 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_fft16.c View 4 chunks +23 lines, -42 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_fft32.c View 3 chunks +23 lines, -43 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_float_fft.c View 3 chunks +17 lines, -33 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_float_rfft.c View 3 chunks +19 lines, -37 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_rfft16_s16.c View 3 chunks +16 lines, -31 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_rfft16_s32.c View 3 chunks +17 lines, -30 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_rfft32.c View 3 chunks +21 lines, -34 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_util.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_util.c View 8 chunks +55 lines, -2 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
rtoy
Please take a look.
7 years, 4 months ago (2013-10-24 21:37:05 UTC) #1
ajm
Nice cleanup. lgtm % nit https://webrtc-codereview.appspot.com/2929004/diff/1/third_party/openmax/dl/sp/src/test/test_util.h File third_party/openmax/dl/sp/src/test/test_util.h (right): https://webrtc-codereview.appspot.com/2929004/diff/1/third_party/openmax/dl/sp/src/test/test_util.h#newcode126 third_party/openmax/dl/sp/src/test/test_util.h:126: nit: Drop this blank ...
7 years, 4 months ago (2013-10-25 10:40:51 UTC) #2
rtoy
7 years, 4 months ago (2013-10-25 16:56:48 UTC) #3
Thanks for the review!

https://webrtc-codereview.appspot.com/2929004/diff/1/third_party/openmax/dl/s...
File third_party/openmax/dl/sp/src/test/test_util.h (right):

https://webrtc-codereview.appspot.com/2929004/diff/1/third_party/openmax/dl/s...
third_party/openmax/dl/sp/src/test/test_util.h:126: 
On 2013/10/25 10:40:51, ajm wrote:
> nit: Drop this blank line.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted