WebRTC Code Reviews
Help | Chromium Project | Sign in
(8507)

Issue 28899004: Revert "Revert part of r7561, "Refactor audio conversion functions."" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by ajm
Modified:
4 years, 9 months ago
Reviewers:
kwiberg
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry, kwiberg, aluebs, Bjorn
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Revert "Revert part of r7561, "Refactor audio conversion functions."" This restores the conversion changes to AudioProcessing originally added in r7561, with minor alterations to ensure it passes all tests. TBR=kwiberg Committed: https://code.google.com/p/webrtc/source/detail?r=7574

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M data/audio_processing/output_data_fixed.pb View Binary file 0 comments Download
M data/audio_processing/output_data_float.pb View Binary file 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 5 chunks +11 lines, -30 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 6 chunks +32 lines, -18 lines 1 comment Download
M webrtc/modules/audio_processing/test/test_utils.h View 2 chunks +23 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
ajm
https://webrtc-codereview.appspot.com/28899004/diff/1/webrtc/modules/audio_processing/test/audio_processing_unittest.cc File webrtc/modules/audio_processing/test/audio_processing_unittest.cc (right): https://webrtc-codereview.appspot.com/28899004/diff/1/webrtc/modules/audio_processing/test/audio_processing_unittest.cc#newcode2125 webrtc/modules/audio_processing/test/audio_processing_unittest.cc:2125: config.Set<ExperimentalAgc>(new ExperimentalAgc(false)); This is the only functional alteration from ...
4 years, 9 months ago (2014-10-31 04:57:46 UTC) #1
ajm
Committed patchset #1 (id:1) manually as 7574 (presubmit successful).
4 years, 9 months ago (2014-10-31 04:58:21 UTC) #2
kwiberg
4 years, 9 months ago (2014-11-03 09:02:09 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted