WebRTC Code Reviews
Help | Chromium Project | Sign in
(1820)

Issue 28609004: Minor modifications to test::RtpFileReader (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by HL
Modified:
4 years, 8 months ago
Reviewers:
pbos
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Minor modifications to test::RtpFileReader Adding original_length to the Packet struct. This is populated with the plen value from the RTP dump file. In the case of reading a pcap file, original_length will be equal to length. Also increasing the maximum packet size to 3500 bytes. This is to accomodate some test files that contain PCM16b audio encoding. R=pbos@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=7333

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixes after pbos's review #

Patch Set 3 : format #

Messages

Total messages: 5 (0 generated)
HL
pbos, Please, review this change. Thanks! /HL
4 years, 8 months ago (2014-09-29 12:30:36 UTC) #1
pbos
https://review.webrtc.org/28609004/diff/1/webrtc/test/rtp_file_reader.h File webrtc/test/rtp_file_reader.h (right): https://review.webrtc.org/28609004/diff/1/webrtc/test/rtp_file_reader.h#newcode27 webrtc/test/rtp_file_reader.h:27: static const size_t kMaxPacketBufferSize = 3500; Explain this number ...
4 years, 8 months ago (2014-09-29 12:45:19 UTC) #2
HL
New patch set uploaded. PTAL. https://review.webrtc.org/28609004/diff/1/webrtc/test/rtp_file_reader.h File webrtc/test/rtp_file_reader.h (right): https://review.webrtc.org/28609004/diff/1/webrtc/test/rtp_file_reader.h#newcode27 webrtc/test/rtp_file_reader.h:27: static const size_t kMaxPacketBufferSize ...
4 years, 8 months ago (2014-09-30 09:33:05 UTC) #3
pbos
lgtm
4 years, 8 months ago (2014-09-30 10:55:16 UTC) #4
HL
4 years, 8 months ago (2014-09-30 11:08:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 7333 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted