WebRTC Code Reviews
Help | Chromium Project | Sign in
(34)

Issue 26329004: Add API to RTCPeerConnection that uses completion blocks instead of

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by hjon
Modified:
1 year, 8 months ago
Reviewers:
tkchin
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry
Base URL:
http://webrtc.googlecode.com/svn/trunk
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add API to RTCPeerConnection that uses completion blocks instead of RTCSessionDescriptionObserver or RTCStatsDelegate BUG=4074

Patch Set 1 #

Patch Set 2 : Change completion to completionHandler and remove unneeded else #

Patch Set 3 : Updating against master #

Patch Set 4 : Add block API for getStats #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M talk/app/webrtc/objc/RTCPeerConnection.mm View 1 2 3 13 chunks +79 lines, -0 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCPeerConnection.h View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Project "webrtc" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
hjon
2 years, 3 months ago (2015-01-27 17:23:30 UTC) #1
hjon
I've updated this patch set against master as of this morning. Does this look good? ...
1 year, 11 months ago (2015-05-20 18:20:52 UTC) #2
hjon
1 year, 8 months ago (2015-08-27 19:55:28 UTC) #3
Updated against master and added block API for getStats.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted