Issue 26329004: Add API to RTCPeerConnection that uses completion blocks instead of

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by hjon

Modified:
4 years, 4 months ago

Reviewers:
tkchin

CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry

Base URL:
http://webrtc.googlecode.com/svn/trunk

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Add API to RTCPeerConnection that uses completion blocks instead of RTCSessionDescriptionObserver or RTCStatsDelegate BUG=4074

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -0 lines)			Patch
	M	talk/app/webrtc/objc/RTCPeerConnection.mm	View	1 2 3	13 chunks	+79 lines, -0 lines	0 comments	Download
	M	talk/app/webrtc/objc/public/RTCPeerConnection.h	View	1 2 3	2 chunks	+16 lines, -0 lines	0 comments	Download

Trybot results: Sign in to try more bots

Project "webrtc" does not have a commit queue.

Total messages: 3 (0 generated)

hjon

I've updated this patch set against master as of this morning. Does this look good? ...

4 years, 8 months ago (2015-05-20 18:20:52 UTC) #2

Updated against master and added block API for getStats.