WebRTC Code Reviews
Help | Chromium Project | Sign in
(1716)

Issue 24669004: Revert "Set minimum SDK level to 10.7 for Mac and iOS" (r7175) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by kjellander
Modified:
4 years, 8 months ago
Reviewers:
tommi, mcasasWebRTC
CC:
webrtc-reviews_webrtc.org, rillian-moz, yujie.mao, ajm, tterriberry, qiang.lu, Niklas
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Revert "Set minimum SDK level to 10.7 for Mac and iOS" (r7175) Reverting this since it didn't fix the build failures. We ended up passing mac_sdk=10.9 in GYP_DEFINES on the bots to to make the build pass again (https://codereview.chromium.org/573673002). BUG=3120 R=mcasas@webrtc.org, tommi@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=7275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander
I'd like to be certain that we're doing the right thing here, so please let ...
4 years, 8 months ago (2014-09-22 08:33:23 UTC) #1
tommi
lgtm
4 years, 8 months ago (2014-09-22 12:50:24 UTC) #2
mcasasWebRTC
lgtm
4 years, 8 months ago (2014-09-23 12:26:00 UTC) #3
kjellander
4 years, 8 months ago (2014-09-23 12:43:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 7275 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted