WebRTC Code Reviews
Help | Chromium Project | Sign in
(9015)

Issue 22659004: Set minimum SDK level to 10.7 for Mac and iOS. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by kjellander
Modified:
4 years, 11 months ago
Reviewers:
tommi, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, rillian-moz, yujie.mao, ajm, tterriberry, qiang.lu, Niklas, mcasasWebRTC, tommi
Base URL:
https://webrtc.googlecode.com/svn/trunk
Visibility:
Public.

Description

Set minimum SDK level to 10.7 for Mac and iOS. This is needed since r7174 introduced a dependency on AVFoundation, which is not present in the 10.6 SDK which is still the default for Chromium. BUG= TESTED=Passing compile on trybots. R=henrika@webrtc.org Committed: https://code.google.com/p/webrtc/source/detail?r=7175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kjellander
4 years, 11 months ago (2014-09-15 07:54:47 UTC) #1
henrika_webrtc
LGTM % (I don't know the details here) CC to mcasas perhaps?
4 years, 11 months ago (2014-09-15 07:57:58 UTC) #2
kjellander
On 2014/09/15 07:57:58, henrik_a wrote: > LGTM % (I don't know the details here) > ...
4 years, 11 months ago (2014-09-15 08:02:30 UTC) #3
kjellander
Committed patchset #1 (id:1) manually as 7175 (presubmit successful).
4 years, 11 months ago (2014-09-15 08:02:50 UTC) #4
tommi
4 years, 11 months ago (2014-09-15 08:23:41 UTC) #5
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted