WebRTC Code Reviews
Help | Chromium Project | Sign in
(10)

Issue 1687004: Removed text relocation code in OpenMax assembly files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Kevin
Modified:
7 years, 8 months ago
Reviewers:
shashishekhar, fbarchard, rtoy, shashishekhar, ajm
Base URL:
http://webrtc.googlecode.com/svn/deps/third_party/openmax/
Visibility:
Public.

Description

Removed text relocation code in OpenMax assembly files. Chromium issue # 8061013 Tested with N-4. Related FFTs' SNR same as before. R=rtoy@google.com Committed: 4261

Patch Set 1 : #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S View 1 2 chunks +3 lines, -7 lines 0 comments Download
M dl/sp/src/armSP_FFT_CToC_SC32_Radix8_fs_unsafe_s.S View 1 1 chunk +5 lines, -7 lines 0 comments Download
M dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S View 1 2 chunks +1 line, -5 lines 0 comments Download
Trybot results:

Messages

Total messages: 9 (0 generated)
Kevin
Shashi, I can't commit to Chromium, so here's a CL in WebRTC. Ray, can you ...
7 years, 8 months ago (2013-06-19 02:20:08 UTC) #1
shashishekhar
On 2013/06/19 02:20:08, Kevin wrote: > Shashi, I can't commit to Chromium, so here's a ...
7 years, 8 months ago (2013-06-19 17:17:18 UTC) #2
ajm
On 2013/06/19 02:20:08, Kevin wrote: > Shashi, I can't commit to Chromium, so here's a ...
7 years, 8 months ago (2013-06-20 00:50:39 UTC) #3
shashishekhar
On 2013/06/20 00:50:39, ajm wrote: > On 2013/06/19 02:20:08, Kevin wrote: > > Shashi, I ...
7 years, 8 months ago (2013-06-20 00:55:27 UTC) #4
rtoy
Sorry for the late reply. I was out of the office. Just a few minor ...
7 years, 8 months ago (2013-06-24 17:55:29 UTC) #5
Kevin
https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S File dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S (right): https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S#newcode185 dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S:185: ORR t0, t0, setStep, LSL #16 On 2013/06/24 17:55:29, ...
7 years, 8 months ago (2013-06-24 22:20:04 UTC) #6
rtoy
https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S File dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S (right): https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S#newcode303 dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S:303: VMOV half[0], t0 On 2013/06/24 22:20:04, Kevin wrote: > ...
7 years, 8 months ago (2013-06-24 22:34:40 UTC) #7
Kevin
https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S File dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S (right): https://webrtc-codereview.appspot.com/1687004/diff/5002/dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S#newcode303 dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S:303: VMOV half[0], t0 On 2013/06/24 22:34:40, rtoy wrote: > ...
7 years, 8 months ago (2013-06-24 22:50:36 UTC) #8
rtoy
7 years, 8 months ago (2013-06-25 16:07:40 UTC) #9
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted