WebRTC Code Reviews
Help | Chromium Project | Sign in
(24)

Issue 11239004: Adding H264 processing to webrtc video engine pipe with a dummy/no-op H264 implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by kaiduanx
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, rillian-moz, interface-changes_webrtc.org, yujie.mao, Patrik, ajm, Stefan, mikhals, perkj, tterriberry, qiang.lu, Niklas, mflodman, HL, leozwang1, andresp-webrtc, rwolff_gocast.it
Base URL:
http://webrtc.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding H264 processing to webrtc video engine pipe with a dummy/no-op H264 implementation

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+829 lines, -2 lines) Patch
M webrtc/build/common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/common_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/engine_configurations.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/interface/module_common_types.h View 1 chunk +11 lines, -1 line 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtp_format_h264.h View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.cc View 3 chunks +64 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 4 chunks +68 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/dummy_h264.gyp View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/dummy_h264_impl.h View 1 2 1 chunk +180 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/dummy_h264_impl.cc View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/include/h264.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/interface/video_codec_interface.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/interface/video_coding_defines.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/codec_database.cc View 5 chunks +31 lines, -0 lines 1 comment Download
M webrtc/modules/video_coding/main/source/encoded_frame.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/internal_defines.h View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/packet.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_coding.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_engine/test/auto_test/source/vie_autotest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 chunk +16 lines, -0 lines 1 comment Download
M webrtc/video_engine/vie_codec_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results: Sign in to try more bots

Messages

Total messages: 6 (0 generated)
juberti_webrtc
Setting reviewers.
5 years, 6 months ago (2014-04-16 22:52:53 UTC) #1
juberti_webrtc
On 2014/04/16 22:52:53, juberti_webrtc wrote: > Setting reviewers. Ami, can you give pointers here to ...
5 years, 6 months ago (2014-04-16 22:54:18 UTC) #2
Ami GONE FROM WEBRTC_CHROMIUM
https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/modules/video_coding/main/source/codec_database.cc File webrtc/modules/video_coding/main/source/codec_database.cc (right): https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/modules/video_coding/main/source/codec_database.cc#newcode130 webrtc/modules/video_coding/main/source/codec_database.cc:130: case VCM_H264_IDX: { It is unfortunate that this patch ...
5 years, 6 months ago (2014-04-16 23:10:40 UTC) #3
kaiduanx
Ami, I am going to follow your instruction with RegisterExternalEncoder(). Thanks, /Kaiduan On Wed, Apr ...
5 years, 6 months ago (2014-04-17 15:17:29 UTC) #4
ksb2go
https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/video_engine/vie_channel.cc File webrtc/video_engine/vie_channel.cc (right): https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/video_engine/vie_channel.cc#newcode231 webrtc/video_engine/vie_channel.cc:231: vcm_.RegisterReceiveCodec(&video_codec264, number_of_cores_); The declaration of vcm_ has changed since ...
5 years, 1 month ago (2014-08-21 21:32:52 UTC) #5
xfengtest01.china
5 years, 1 month ago (2014-08-22 09:55:18 UTC) #6
On 2014/08/21 21:32:52, ksb2go wrote:
>
https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/video_engine...
> File webrtc/video_engine/vie_channel.cc (right):
> 
>
https://webrtc-codereview.appspot.com/11239004/diff/20002/webrtc/video_engine...
> webrtc/video_engine/vie_channel.cc:231:
> vcm_.RegisterReceiveCodec(&video_codec264, number_of_cores_);
> The declaration of vcm_ has changed since this patch and would require some
> update. vcm_ is now a type VideoCodingModule*, so should be
> vcm_->RegisterReceiveCodec here.


Hi All,

Thanks for this patch, I have commit this patch. In my two test cases(video with
H.264 codec), one is okey and other is fail. Can you help take a check?
CaseA: the peer-1 under NAT call the peer-2 which not under NAT, video streaming
well.
CaseB: the peer-2 which not under NAT call the peer-1 which under NAT, the
peer-1 will be crashed, log msg shows as below, 
    ...
Error(common.cc:76): talk/p2p/base/transportchannelproxy.cc(61): ASSERT FAILED:
false @ SetImplementation
Trace/breakpoint trap

PS: If seting the video codec type as VP8, video streaming well with the two
test cases(CaseA and CaseB).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted