WebRTC Code Reviews
Help | Chromium Project | Sign in
(439)

Issue 1120006: Add supporting to V4L2_PIX_FMT_JPEG since it works same as MJPEG (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by braveyao1
Modified:
7 years, 3 months ago
Reviewers:
perkj
CC:
webrtc-reviews_webrtc.org, rillian-moz, tterriberry, perkj, mflodman, leozwang1
Base URL:
http://webrtc.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add supporting to V4L2_PIX_FMT_JPEG since it works same as MJPEG. ISSUE=529 TEST=unittest Committed: https://code.google.com/p/webrtc/source/detail?r=3580

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webrtc/modules/video_capture/linux/video_capture_linux.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
Trybot results:

Messages

Total messages: 4 (0 generated)
braveyao1
Add FMT_JPEG as discussed. PTAL!
7 years, 3 months ago (2013-02-27 08:20:12 UTC) #1
perkj
lgtm if the below is addressed. https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_capture/linux/video_capture_linux.cc File webrtc/modules/video_capture/linux/video_capture_linux.cc (right): https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_capture/linux/video_capture_linux.cc#newcode160 webrtc/modules/video_capture/linux/video_capture_linux.cc:160: fmts[1] = V4L2_PIX_FMT_JPEG; ...
7 years, 3 months ago (2013-02-27 08:48:00 UTC) #2
braveyao1
Please check my comments. https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_capture/linux/video_capture_linux.cc File webrtc/modules/video_capture/linux/video_capture_linux.cc (right): https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_capture/linux/video_capture_linux.cc#newcode160 webrtc/modules/video_capture/linux/video_capture_linux.cc:160: fmts[1] = V4L2_PIX_FMT_JPEG; But for ...
7 years, 3 months ago (2013-02-27 08:56:59 UTC) #3
braveyao1
7 years, 3 months ago (2013-02-27 09:24:41 UTC) #4
Done, as discussed.

https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_cap...
File webrtc/modules/video_capture/linux/video_capture_linux.cc (right):

https://webrtc-codereview.appspot.com/1120006/diff/1/webrtc/modules/video_cap...
webrtc/modules/video_capture/linux/video_capture_linux.cc:160: fmts[1] =
V4L2_PIX_FMT_JPEG;
On 2013/02/27 08:57:00, braveyao1 wrote:
> But for larger resolution, shouldn't we prefer compressed format, giving we
> assuming FMT_JPEG == FMT_MJPEG?
> 
> On 2013/02/27 08:48:00, perkj1 wrote:
> > I think you should set fmts[3]= V4L2_PIX_FMT_JPEG instead of 1. Ie put it as
> the
> > last priority.
> 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted