WebRTC Code Reviews
Help | Chromium Project | Sign in
(18)

Issue 1095004: Update paths for the new directory structure. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by rtoy
Modified:
8 years ago
Reviewers:
kma, Kevin, ajm
Base URL:
https://webrtc.googlecode.com/svn/deps
Visibility:
Public.

Description

Update paths for the new directory structure. Source paths in the gyp files and include paths in all files are updated to the new directory structure. Committed: 3472

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -275 lines) Patch
M third_party/openmax/dl/dl.gyp View 1 1 chunk +50 lines, -47 lines 0 comments Download
M third_party/openmax/dl/sp/api/armSP.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/api/omxSP.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFTInv_CCSToR_F32_preTwiddleRadix2_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFTInv_CCSToR_S32_preTwiddleRadix2_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix2_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix2_ls_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix2_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix4_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix4_ls_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix4_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_FC32_Radix8_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix2_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix2_ls_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix2_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix4_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix4_ls_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix4_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_CToC_SC32_Radix8_fs_unsafe_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_F32TwiddleTable.c View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/src/armSP_FFT_S32TwiddleTable.c View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTFwd_CToC_FC32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTFwd_CToC_SC32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTFwd_RToCCS_F32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTFwd_RToCCS_S16S32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTFwd_RToCCS_S32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_C_FC32.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_C_SC16.c View 1 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_C_SC32.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_R_F32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_R_S16S32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTGetBufSize_R_S32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_C_FC32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_C_SC16.c View 1 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_C_SC32.c View 1 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_R_F32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_R_S16S32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInit_R_S32.c View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInv_CCSToR_F32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInv_CCSToR_S32S16_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInv_CCSToR_S32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInv_CToC_FC32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/omxSP_FFTInv_CToC_SC32_Sfs_s.S View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/aligned_ptr.c View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/src/test/compare.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/compare.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/gensig.c View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/dl/sp/src/test/test_fft.gyp View 1 2 5 chunks +18 lines, -63 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_fft32.c View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_fft_time.c View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_float_fft.c View 1 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_float_rfft.c View 1 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_rfft16.c View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_rfft32.c View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_util.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/openmax/dl/sp/src/test/test_util.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
Trybot results:

Messages

Total messages: 8 (0 generated)
rtoy
Please review this at your convenience. One question I have: The include paths are updated ...
8 years ago (2013-02-04 18:17:38 UTC) #1
ajm
https://webrtc-codereview.appspot.com/1095004/diff/1/third_party/openmax/dl/dl.gyp File third_party/openmax/dl/dl.gyp (right): https://webrtc-codereview.appspot.com/1095004/diff/1/third_party/openmax/dl/dl.gyp#newcode19 third_party/openmax/dl/dl.gyp:19: '.', There are two other reasonable alternatives I can ...
8 years ago (2013-02-04 22:56:27 UTC) #2
ajm
8 years ago (2013-02-04 22:56:36 UTC) #3
rtoy
https://webrtc-codereview.appspot.com/1095004/diff/1/third_party/openmax/dl/dl.gyp File third_party/openmax/dl/dl.gyp (right): https://webrtc-codereview.appspot.com/1095004/diff/1/third_party/openmax/dl/dl.gyp#newcode19 third_party/openmax/dl/dl.gyp:19: '.', On 2013/02/04 22:56:27, ajm wrote: > There are ...
8 years ago (2013-02-04 23:01:19 UTC) #4
ajm
lgtm with one possible change. https://webrtc-codereview.appspot.com/1095004/diff/7001/third_party/openmax/dl/sp/src/test/test_fft.gyp File third_party/openmax/dl/sp/src/test/test_fft.gyp (right): https://webrtc-codereview.appspot.com/1095004/diff/7001/third_party/openmax/dl/sp/src/test/test_fft.gyp#newcode69 third_party/openmax/dl/sp/src/test/test_fft.gyp:69: 'conditions': [ If you ...
8 years ago (2013-02-05 02:27:11 UTC) #5
rtoy
On 2013/02/05 02:27:11, ajm wrote: > lgtm with one possible change. > > https://webrtc-codereview.appspot.com/1095004/diff/7001/third_party/openmax/dl/sp/src/test/test_fft.gyp > ...
8 years ago (2013-02-05 17:10:19 UTC) #6
Kevin
lgtm On 2013/02/05 17:10:19, rtoy wrote: > On 2013/02/05 02:27:11, ajm wrote: > > lgtm ...
8 years ago (2013-02-05 17:17:28 UTC) #7
rtoy
8 years ago (2013-02-05 17:23:33 UTC) #8
Thanks for reviewing this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 245c2c2-tainted